Fixed issue with wrong value used for the smf file. Pymapconv expects the output file to be without extension which is now the case

Author: adras

MapCreationTool/MapCreationTool/Helpers/PathHelper.cs

@@ -51,6 +51,16 @@ internal static string GetWorkDirFromFullMapPath(string fullMapPath)
             return result;
 		}
 
+        internal static string GetFilePathWithoutExtension(string filePath)
+        {
+            FileInfo fileInfo = new FileInfo(filePath);
+            string directoryPath = fileInfo.Directory.FullName;
+            string fileName = Path.GetFileNameWithoutExtension(filePath);
+            string result = Path.Combine(directoryPath, fileName);
+            
+            return result;
+        }
+
         /// <summary>
         /// Returns true if the given map path is actually containing a map
         /// </summary>
@@ -60,7 +70,7 @@ internal static string GetWorkDirFromFullMapPath(string fullMapPath)
         /// No maps subdirectory -> Not a map
         /// A bit troublesome if the user stores their map in a related directory
         /// </remarks>
-		internal static bool IsMapDirectory(string fullMapPath)
+        internal static bool IsMapDirectory(string fullMapPath)
 		{
             string mapsPath = Path.Combine(fullMapPath, "maps");
             if (!Directory.Exists(mapsPath))

MapCreationTool/MapCreationTool/MapConverter/ProjectSettingsToCompilerSettingsConverter.cs

@@ -1,6 +1,8 @@
-using MapCreationTool.Models;
+using MapCreationTool.Helpers;
+using MapCreationTool.Models;
 using System;
 using System.Collections.Generic;
+using System.IO;
 using System.Linq;
 using System.Text;
 using System.Threading.Tasks;
@@ -39,7 +41,11 @@ public static PyMapCompilerSettings Convert(ProjectSettings projectSettings)
             CompilationSettings compSettings = projectSettings.CompilationSettings;
             PyMapCompilerSettings settings = new PyMapCompilerSettings();
             SettingsAdder adder = new SettingsAdder(settings);
-            adder.AddSettingIfSet("-o", compSettings.OutSmfFilePath, true);
+
+            // we don't want the outsmfFilepath to have any extension. Therefore we remove it. It will be automatically added by pymapconv again
+            string outSmtPath = PathHelper.GetFilePathWithoutExtension(compSettings.OutSmfFilePath);
+
+            adder.AddSettingIfSet("-o", outSmtPath, true);
             adder.AddSettingIfSet("-t", compSettings.DiffuseMapName, true);
             adder.AddSettingIfSet("-a", compSettings.HeightMapName, true);
             adder.AddSettingIfSet("-m", compSettings.MetalMapName, compSettings.UseMetalMap);