Skip to content

Added a step that renders the readme #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 3, 2020
Merged

Added a step that renders the readme #77

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
22ed3e4
Added a step that renders the readme
evaherrada Jul 1, 2020
9306a05
Put readme test in the right place
evaherrada Jul 1, 2020
563f954
Installing without --user
evaherrada Jul 1, 2020
031ce24
Renamed to build python package
evaherrada Jul 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions {{ cookiecutter.library_name }}/.github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,3 +59,9 @@ jobs:
- name: Build docs
working-directory: docs
run: sphinx-build -E -W -b html . _build/html
- name: Build README
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd call this Build python package since it'll fail if the setup.py steps fail. Otherwise, this looks good to me.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I've renamed it. Thanks for taking a look at this

run: |
pip install --upgrade setuptools wheel twine readme_renderer testresources
python setup.py sdist
python setup.py bdist_wheel --universal
twine check dist/*