Skip to content

Always generate PyPI infrastructure #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 31, 2022
Merged

Conversation

tekktrik
Copy link
Member

Per @jepler's and @evaherrada's work to ensure all packages are available on PyPI for Mu, this PR updates the cookiecutter so that this infrastructure is always generated and is no longer one of the configurable options.

Resolves #191

@tekktrik tekktrik requested a review from a team August 24, 2022 03:07
Copy link
Contributor

@askpatrickw askpatrickw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see this in the Issue or the comments, maybe it was discussed elsewhere. What happens for community libraries? What else do they need to do to set that up?

@tekktrik
Copy link
Member Author

Community libraries need to set up things in the repository like secrets, but there's no downside for community libraries for providing the infrastructure, even if they don't use it.

@askpatrickw
Copy link
Contributor

Since the GH Action is part of the template, it would be good to document that in the README.rst.

https://github.com/adafruit/cookiecutter-adafruit-circuitpython/blob/main/%7B%7B%20cookiecutter.__dirname%20%7D%7D/.github/workflows/release.yml#L60

- name: Build and publish
      if: contains(steps.need-pypi.outputs.pyproject-toml, 'pyproject.toml')
      env:
        TWINE_USERNAME: {% raw %}${{ secrets.pypi_username }}{% endraw %}
        TWINE_PASSWORD: {% raw %}${{ secrets.pypi_password }}{% endraw %}

Added steps for using GitHub Releases for Community libraries
@tekktrik tekktrik requested a review from askpatrickw August 31, 2022 02:48
@tekktrik
Copy link
Member Author

Added instruction to cookiecutter repo README for adding secrets

Copy link
Contributor

@kattni kattni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Did not test it. @tekktrik Looks like pre-commit is failing. Feel free to merge once the PR is passing, unless you make major changes in the meantime, in which case, mark it ready for re-review. Thanks!

@tekktrik
Copy link
Member Author

Rebased this, to get access to the formatting but otherwise the same

@tekktrik tekktrik merged commit a138f84 into adafruit:main Aug 31, 2022
@tekktrik tekktrik deleted the dev/always-pypi branch December 1, 2022 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Always publish packages to PyPI
3 participants