-
Notifications
You must be signed in to change notification settings - Fork 37
Always generate PyPI infrastructure #200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see this in the Issue or the comments, maybe it was discussed elsewhere. What happens for community libraries? What else do they need to do to set that up?
Community libraries need to set up things in the repository like secrets, but there's no downside for community libraries for providing the infrastructure, even if they don't use it. |
Since the GH Action is part of the template, it would be good to document that in the README.rst. - name: Build and publish
if: contains(steps.need-pypi.outputs.pyproject-toml, 'pyproject.toml')
env:
TWINE_USERNAME: {% raw %}${{ secrets.pypi_username }}{% endraw %}
TWINE_PASSWORD: {% raw %}${{ secrets.pypi_password }}{% endraw %} |
Added steps for using GitHub Releases for Community libraries
Added instruction to cookiecutter repo README for adding secrets |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Did not test it. @tekktrik Looks like pre-commit is failing. Feel free to merge once the PR is passing, unless you make major changes in the meantime, in which case, mark it ready for re-review. Thanks!
Rebased this, to get access to the formatting but otherwise the same |
Per @jepler's and @evaherrada's work to ensure all packages are available on PyPI for Mu, this PR updates the cookiecutter so that this infrastructure is always generated and is no longer one of the configurable options.
Resolves #191