Skip to content

Mpy size actions #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Mpy size actions #197

Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c2d2270
adding mpy size actions comment
FoamyGuy Aug 18, 2022
4a8cbe2
add raw tags
FoamyGuy Aug 18, 2022
96fd6cb
update actions task for conditional comment
FoamyGuy Aug 25, 2022
f539521
fix raw tag
FoamyGuy Aug 25, 2022
730d4b0
use checkout action to clone
FoamyGuy Aug 25, 2022
5c3eb22
remove extra space
FoamyGuy Aug 29, 2022
dde0226
clone and build main branch for size measurements
FoamyGuy Sep 24, 2022
549f559
fix template var
FoamyGuy Sep 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions {{ cookiecutter.__dirname }}/.github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,17 @@ jobs:
pre-commit run --all-files
- name: Build assets
run: circuitpython-build-bundles --filename_prefix {% raw %}${{ steps.repo-name.outputs.repo-name }}{% endraw -%} {% if cookiecutter.target_bundle == 'Community' %} --package_folder_prefix {% if cookiecutter.library_prefix -%} {{ cookiecutter.library_prefix | lower | replace(' ', '_') }}_ {%- else %}""{%- endif -%}{%- endif %} --library_location .
- name: Check Sizes
run: |
git clone https://github.com/FoamyGuy/CircuitPython_Memory_Tools.git
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should that move to https://github.com/circuitpython ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do like that idea. I'll cookiecut a new one to get the relavent boilerplate stuff and move this code into it, then put it in the circuitpython org. Probably sometime tomorrow I can work on that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Repo now lives here: https://github.com/circuitpython/CircuitPython_Org_size_tools

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still need to update this PR to point to the new one. Will make a new commit with that once I've got the conditions mentioned in the other comment worked out.

python CircuitPython_Memory_Tools/measure_size.py > sizes.txt
- name: Size Measurement Comment
if: github.event_name == 'pull_request'
uses: machine-learning-apps/pr-comment@master
env:
GITHUB_TOKEN: {% raw %}${{ secrets.GITHUB_TOKEN }} {% endraw %}
with:
path: sizes.txt
- name: Archive bundles
uses: actions/upload-artifact@v2
with:
Expand Down