Allow bundles to be skipped #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needed to close out adafruit/Adafruit_CircuitPython_Typing#34 |
jepler
suggested changes
Jul 25, 2023
| @@ -234,7 +234,10 @@ def _find_libraries(current_path, depth): | |||
| @click.option('--library_depth', default=0, help="Depth of library folders. This is useful when multiple libraries are bundled together but are initially in separate subfolders.") | |||
| @click.option('--package_folder_prefix', default="adafruit_", help="Prefix string used to determine package folders to bundle.") | |||
| @click.option('--remote_name', default="origin", help="Git remote name to use during building") | |||
| def build_bundles(filename_prefix, output_directory, library_location, library_depth, package_folder_prefix, remote_name): | |||
| @click.option('--ignore', default="", help="Bundles to ignore building") | |||
There was a problem hiding this comment.
I'm not tickled about the separator being ", " since this requires shell quoting --ignore "py, mpy" and is easy to get wrong, --ignore py,mpy is an undiagnosed error.
If you use @click.option('--ignore', '-i', multiple=True, type=click.Choice(["py", "mpy", "json"])) then you don't have to do the parsing, you just give zero or more --ignore arguments, and errors are detected.
There was a problem hiding this comment.
Good catch! I also felt not great about that, but your suggestion is MUCH more elegant. I'll fix this up this evening!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows bundles to be skipped from being built. This is useful when libraries that do not need specific bundles (e.g.,
circuitpython_typingdoes not need.mpybundles) are built.