move all_platforms to its own file #149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
yah sorry i didnt see this, its ok but will need conflicts resolved |
|
ah, I forgot about this as well, will update & resolve the conflict soon ... |
|
@hathach wanna try now that you're done with some recent projects? |
hathach
force-pushed
the
separate-platform-definiton
branch
from
ef747b0 to
317c7cc
Compare
|
@ladyada yeah, just bump it up to lastest and resolve conflict. Should be good for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
move
ALL_PLATFORMSto its own file all_platforms.py to make it easier for other repo to re-use the definitions. This is sometime is useful for other repo without maintaining the list locally.