Add build.esptool_extra to allow optionally flash factory app #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ill merge to test and then give you feedback |
The only reason why I used |
This was referenced Apr 13, 2021
Merged
me-no-dev
pushed a commit
to espressif/arduino-esp32
that referenced
this pull request
Apr 15, 2021
…oad.extra_flags (#5056) done on behalf of @ladyada, this PR does: Add Adafruit FunHouse and upcoming Adafruit Feather Esp32s2 Update Adafruit magtag and metro esp32s2 to have tinyuf2 as factory app Also modify platform.txt as discussed in adafruit#2 + adafruit#3 + adafruit#4 to add support for Board/variant partition.csv, bootloader.bin ( priority is user sketch > variant > build.parition/boot ) upload.extra_flags to optionally flash tinyuf2 as factory application Remove duplicated parameter in running python script in linux and windows Please review and let me know if you want any changes. Notes: tinyuf2 is a uf2 bootloader for multiple platforms. For esp32s2, it is an factory app to perform uf2 firmware update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows variant to bundle factory app such as tinyuf2 to esptool flashing command. This way it is guarantee to always work as expected even user accidentally overwrite factory app (e.g selecting incorrect board & flash previously). This follows suggestion by #2 (comment) using
build.esptool_extrawork great, though since it is only used in upload, maybe we could rename it toupload.extra_flags, it is totally up to @me-no-dev to decide.