Split TravisCI build into one job per variant #373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows TravisCI integration for forks on free accounts. Those would otherwise fail, due to a hard-coded and non-configurable 50 minute job limt imposed by TravisCI. This will also help avoid the 120 minute job limit that applies to non-free accounts, which the current builds are quickly approaching....
hathach
reviewed
Nov 5, 2019
| fail_count += 1 | ||
| exit_status = -1 | ||
|
|
||
| else: # no environment variable specified, so build all variants |
There was a problem hiding this comment.
nice that you keep the build all option, I usually run this locally before pushing when doing major changes.
There was a problem hiding this comment.
Yes, I noticed that you checked for travis, and so I thought this might be the case. 👍
hathach
approved these changes
Nov 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #371
TravisCI imposes a per-job time limit. This limit is fixed and non-configurable for free accounts as
50minutes. This limit is configurable but cannot exceed120minutes for enterprise / paid accounts.The builds are currently taking approximately 75 minutes, building all samples for three distinct boards (variants) in a single job. Because 75 minutes is greater than 50 minutes, this prevents users with only a free account from validating their changes using TravisCI prior to submitting their pull requests.
This change also dramatically reduces the (wall-clock) time for validation of a successful build (from ~75 minutes down to ~30 minutes).