This repository was archived by the owner on Oct 25, 2019. It is now read-only.
Refacto, fix PR #3 , added instruments inclinometer and heading . #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eloylp
commented
Aug 25, 2017
•
eloylp
commented
- Refactoring the main file, preserving public interfaces.
- Fix previous bug also resolved in PR Fix set_mag_gain definition and add to the example #3
- Add heading (and example) instrument ready to use in projects.
- Add inclinometer (and example, pitch and roll) instrument, for each axis (x, y)
- Improved examples code and stdout.
- Tests
added 24 commits
August 22, 2017 12:55
|
Thank you. This is a really nice contribution. This library has been replaced by two new libraries, one for each sensor in the LSM303DLH: https://github.com/adafruit/Adafruit_CircuitPython_LSM303_Accel I've added issues to the new libraries (and an associated one) to add similar features. If you can submit a PR or two, that would be great. Otherwise I'll get to it when I can. adafruit/Adafruit_CircuitPython_LSM303_Accel#2 Thank you for your contribution |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.