fix for sparkle motion mini warning #3044
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The new commit has the same fix for the big sparkle motion, I also tested the updated code on that hardware successfully. I'm unclear about why the GH actions seem to flag this as a failure under gemma and put the X next to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this change should resolve this actions failure resulting from a warning about comparing signed with unsigned types: https://github.com/adafruit/Adafruit_Learning_System_Guides/actions/runs/15316694255/job/43091814706#step:7:902
The issue boils down to
Adafruit_Neopixel.numPixels()returning an unsigned value, butint i = 0from the loop variable being signed.I tested the modified version successfully on the sparkle motion mini with two 1x8 NeoPixel strips.