Skip to content

adding code for the alphanumeric countdown clock #2340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 29, 2022
Merged

Conversation

BlitzCityDIY
Copy link
Collaborator

Adding code for the alphanumeric countdown clock. Uses three alphanumeric displays with a qt py esp32-s2. gets the time from adafruit IO and compares it to the time set for the event at the top of the code.

Adding code for the alphanumeric countdown clock
@BlitzCityDIY
Copy link
Collaborator Author

BlitzCityDIY commented Nov 29, 2022

looks like it's failing here on CI:

TrinketReactCounter_7segment.ino adafruit:avr:gemma build output
  /home/runner/.arduino15/packages/adafruit/hardware/avr/1.4.15/libraries/Wire/USI_TWI_Master.cpp: In function 'unsigned char TinyM_USI_TWI_Master_Transfer(unsigned char)':
  /home/runner/.arduino15/packages/adafruit/hardware/avr/1.4.15/libraries/Wire/USI_TWI_Master.cpp:276:5: warning: this 'while' clause does not guard... [-Wmisleading-indentation]
       while( !(PIN_USI & (1<<PIN_USI_SCL)) );// Wait for SCL to go high.
       ^~~~~

which is this file in the Wire library: https://github.com/adafruit/Adafruit_Arduino_Boards/blob/master/libraries/Wire/USI_TWI_Master.cpp

@jepler
Copy link
Contributor

jepler commented Nov 29, 2022

I think the actual error is "error: 'SPI' was not declared in this scope":


  Used library                      Version Path                                                                        
  Adafruit LiquidCrystal            2.0.0   /home/runner/Arduino/libraries/Adafruit_LiquidCrystal                       
  Adafruit MCP23017 Arduino Library 2.2.0   /home/runner/Arduino/libraries/Adafruit_MCP23017_Arduino_Library            
  Adafruit BusIO                    1.14.1  /home/runner/Arduino/libraries/Adafruit_BusIO                               
  Wire                              1.0     /home/runner/.arduino15/packages/adafruit/hardware/avr/1.4.15/libraries/Wire
  
  Used platform Version Path                                                         
  adafruit:avr  1.4.15  /home/runner/.arduino15/packages/adafruit/hardware/avr/1.4.15
  arduino:avr   1.8.6   /home/runner/.arduino15/packages/arduino/hardware/avr/1.8.6
  In file included from /home/runner/Arduino/libraries/Adafruit_MCP23017_Arduino_Library/src/Adafruit_MCP23X08.h:8:0,
                   from /home/runner/Arduino/libraries/Adafruit_LiquidCrystal/Adafruit_LiquidCrystal.h:9,
                   from /home/runner/work/Adafruit_Learning_System_Guides/Adafruit_Learning_System_Guides/Trinket_Ultrasonic_Rangefinder/Trinket_Ultrasonic_Rangefinder.ino:30:
  /home/runner/Arduino/libraries/Adafruit_MCP23017_Arduino_Library/src/Adafruit_MCP23XXX.h:44:54: error: 'SPI' was not declared in this scope
     bool begin_SPI(uint8_t cs_pin, SPIClass *theSPI = &SPI,
                                                        ^~~
  /home/runner/Arduino/libraries/Adafruit_MCP23017_Arduino_Library/src/Adafruit_MCP23XXX.h:44:54: note: suggested alternative: 'SPH'
     bool begin_SPI(uint8_t cs_pin, SPIClass *theSPI = &SPI,
                                                        ^~~
                                                        SPH
  Multiple libraries were found for "Wire.h"
    Used: /home/runner/.arduino15/packages/adafruit/hardware/avr/1.4.15/libraries/Wire
    Not used: /home/runner/.arduino15/packages/arduino/hardware/avr/1.8.6/libraries/Wire

The other says "warning:" so it should not stop or fail the build process.

@TheKitty
Copy link
Collaborator

TheKitty commented Nov 29, 2022 via email

@jepler
Copy link
Contributor

jepler commented Nov 29, 2022

@caternuson do you have a moment to take a look at this? It looks like the library always expects 'SPI' to be available, but https://github.com/adafruit/Adafruit_BusIO/blob/master/Adafruit_SPIDevice.h doesn't define SPI if SPI_INTERFACES_COUNT is zero or undefined. However, this is not a recent change, so not sure why it didn't come up before now.

@caternuson
Copy link
Contributor

It's because of this:
adafruit/Adafruit_LiquidCrystal#15
with the real issue being with the current state of the MCP23017 library - that's the one that expects/requires SPI and Wire to exist.

For now, to get this PR to pass CI, suggest adding a gemma.test.skip file to the PR.

@BlitzCityDIY
Copy link
Collaborator Author

great, thanks @caternuson ! i'll add that

@TheKitty
Copy link
Collaborator

Skip files can be picky. I suggest cancelling this PR and put in a new one with the exact current files.

@BlitzCityDIY
Copy link
Collaborator Author

going to be trying with a new PR to include the skip on initial commit

@TheKitty TheKitty merged commit db5948e into main Nov 29, 2022
@BlitzCityDIY BlitzCityDIY deleted the alphanumeric_countdown branch November 29, 2022 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants