Add travis-ci config for running pylint #164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks so much for doing this! We're super excited! We're waiting on finalising adding what we're going to have pylint ignore before merging this. |
Updated the pylintrc disable line to include a majority of the suggestions from @craigargh A detailed explanation of each disable added can be found here: adafruit#2 I chose to leave out anything that Craig stated could or should be refactored, including things he said he didn't have the eq to test etc.
|
Ok, this is ready to merge! Thanks so much to @dylwhich for the great work! |
kattni
approved these changes
May 16, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.circuitpython.skipfile, per Use pylint to lint check all examples #2.pylintrc, mostly copied from adafruit/cookiecutter-adafruit-circuitpython but disabledmissing-docstring,invalid-name,bad-whitespace, andImport-erroras used for other examples.