Update PyPortal_MQTT_Control #1122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ladyada
approved these changes
May 27, 2020
|
@RichardA1 hihi wanna test this updated code? |
|
Ah, yes I should be able to get the PyPortal out and test it today. |
|
@RichardA1 hihi - dya have any cycles to test out this code fix? :) |
|
@RichardA1 Have you been able to test this patch? |
|
@RichardA1 Have you been able to test this patch? |
|
Yeah, I tested it out and it worked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant Issue: #1110
Updating PyPortal_MQTT_Control to reflect the latest version of the MiniMQTT library.
Note: This code is untested. The guide's (https://learn.adafruit.com/pyportal-mqtt-sensor-node-control-pad-home-assistant/code-breakdown) code walkthrough page does not reference this method signature and does not need an update.