Support boards that don't have a fixed I2C bus. #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsbohn
commented
Jan 29, 2021
jepler
suggested changes
Jan 29, 2021
There was a problem hiding this comment.
Thank you! I believe this is a good change. In Python, the default value of a function argument is evaluated when the function's definition is encountered, so it should be something that can always succeed and has no "side effects"; even on boards that have board.I2C(), simply calling board.I2C() can have a side effect: it reserves those pins and does not let them be used for other purposes.
A minor change, though: It is better in Python to say if i2c_bus is None, according to the Style Guide for Python Code
Making this change should resolve the problems detected by the automatic checks.
jepler
reviewed
Jan 29, 2021
Based on guidance from jepler.
Suggested by pylint. TFTShield won't work without an i2c_bus, so fail with an informative message.
jepler
approved these changes
Jan 29, 2021
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Feb 3, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_SCD30 to 2.0.1 from 2.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_SCD30#7 from rpavlik/pressure-type Updating https://github.com/adafruit/Adafruit_CircuitPython_Seesaw to 1.7.0 from 1.6.4: > Merge pull request adafruit/Adafruit_CircuitPython_seesaw#58 from adafruit/dherrada-patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_seesaw#59 from rsbohn/master Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 2.12.1 from 2.11.2: > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#112 from jposada202020/updating-docs > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#110 from FoamyGuy/bitmap_label_ascent_descent Updating https://github.com/adafruit/Adafruit_CircuitPython_Slideshow to 1.5.5 from 1.5.4: > Merge pull request adafruit/Adafruit_CircuitPython_Slideshow#35 from adafruit/dherrada-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Added the following libraries: Adafruit_CircuitPython_SimpleMath
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #57 -- allows loading tftshield18 on the Raspberry Pi Pico.
Preserves the existing behavior on devices with board.I2C.
The Pico doesn't have a pre-defined I2C, you have to set it up with busio before you can instantiate the TFTShield18 object.