Skip to content

remove bad-whitespace pylint directive #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 28, 2020
Merged

remove bad-whitespace pylint directive #52

merged 3 commits into from
Aug 28, 2020

Conversation

jepler
Copy link
Contributor

@jepler jepler commented Aug 23, 2020

This directive has been removed from pylint 2.6.0.

@dhalbert dhalbert requested a review from a team August 23, 2020 17:11
@kattni
Copy link
Contributor

kattni commented Aug 24, 2020

@jepler I researched this. You need to go through the two modules, keypad and tftshield18, and remove the arguments from the super(foo, self).__init__(args). There are only two places, despite the Pylint check including four items (they are two things, each duplicated).

makermelissa
makermelissa approved these changes Aug 27, 2020
View reviewed changes
Copy link
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@makermelissa makermelissa merged commit 9d91ec8 into adafruit:master Aug 28, 2020
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Sep 1, 2020
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@b17b8fd)
9a5a828 
Updating https://github.com/adafruit/Adafruit_CircuitPython_DHT to 3.5.1 from 3.5.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_DHT#48 from adafruit/lint
  > Merge pull request adafruit/Adafruit_CircuitPython_DHT#47 from michaellass/start_paused

Updating https://github.com/adafruit/Adafruit_CircuitPython_DPS310 to 1.2.0 from 1.1.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_DPS310#9 from caternuson/iss8

Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 3.5.0 from 3.4.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#105 from makermelissa/master
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#104 from jepler/remove-bad-whitespace-directive

Updating https://github.com/adafruit/Adafruit_CircuitPython_IS31FL3731 to 2.6.5 from 2.6.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_IS31FL3731#31 from esmil/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_Seesaw to 1.6.3 from 1.6.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_seesaw#52 from jepler/remove-bad-whitespace-directive

Updating https://github.com/adafruit/Adafruit_CircuitPython_AdafruitIO to 4.1.0 from 4.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_AdafruitIO#44 from makermelissa/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_MatrixPortal to 1.3.0 from 1.1.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_MatrixPortal#13 from makermelissa/master
  > Merge pull request adafruit/Adafruit_CircuitPython_MatrixPortal#12 from makermelissa/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_Motor to 3.2.2 from 3.2.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_Motor#48 from kattni/update-example

Updating https://github.com/adafruit/Adafruit_CircuitPython_Requests to 1.6.0 from 1.5.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_Requests#30 from tannewt/add_tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makermelissa makermelissa makermelissa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jepler @kattni @makermelissa