Skip to content

Eliminate duplicated code in pin_mode_bulk* #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 26, 2019
Merged

Eliminate duplicated code in pin_mode_bulk* #36

merged 1 commit into from
Jul 26, 2019

Conversation

zostay
Copy link
Contributor

@zostay zostay commented Jul 9, 2019

This is a modest adjustment to pin_mode_bulk and pin_mode_bulk_b which should be functionally equivalent, but avoid duplicated code.

@zostay zostay force-pushed the cleanup-pin_mode_bulk branch from 126f24e to e0fd3df Compare July 9, 2019 02:34
makermelissa
makermelissa approved these changes Jul 26, 2019
View reviewed changes
Copy link
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid. Tested with pin_mode_bulk and it worked great. Thanks for doing this.

@makermelissa makermelissa merged commit a0fcd3f into adafruit:master Jul 26, 2019
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jul 26, 2019
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@1939062)
0d5e008 
Updating https://github.com/adafruit/Adafruit_CircuitPython_ILI9341 to 1.0.3 from 1.0.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_ILI9341#8 from makermelissa/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_Seesaw to 1.5.1 from 1.4.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_seesaw#36 from zostay/cleanup-pin_mode_bulk
  > Merge pull request adafruit/Adafruit_CircuitPython_seesaw#39 from makermelissa/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_Requests to v1.0.1 from v1.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_Requests#3 from brentru/update-examples

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Added the following libraries: Adafruit_CircuitPython_DisplayIO_SSD1306, Adafruit_CircuitPython_SSD1322, Adafruit_CircuitPython_SSD1325, Adafruit_CircuitPython_SSD1327, Adafruit_CircuitPython_Requests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makermelissa makermelissa makermelissa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zostay @makermelissa