add delay to I2Cread for temperature reading #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ladyada
approved these changes
Jun 23, 2019
|
yep could definitely be related to speedups in the core + M4 being so fast. thanks for catching! |
|
@jerryneedell - wanna bump? |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jun 24, 2019
Updating https://github.com/adafruit/Adafruit_CircuitPython_Seesaw to 1.4.2 from 1.4.1: > Merge pull request adafruit/Adafruit_CircuitPython_seesaw#34 from jerryneedell/jerryn_soil Updating https://github.com/adafruit/Adafruit_CircuitPython_ to 1.0.3 from 1.0.2: > Merge pull request adafruit/Adafruit_CircuitPython_#8 from dastels/master > Merge pull request adafruit/Adafruit_CircuitPython_#7 from dastels/master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
temperature reading had been working in the past, but now temperature readings were not being returned correctly. Not sure what changed but increasing the delay for the read fixed the problem.
This delay was already used for the moisture reading.
fixes #33
Is this possibly due to recent "speedups" in CP in general? Will other seesaw applications run into similar issues? Is the default delay of .001 sufficient?
tested on feather_m4_express and pyportal