Skip to content

Fix neopixel for python version of adafruit_pixelbuf #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2022

Conversation

Neradoc
Copy link
Contributor

@Neradoc Neradoc commented Jul 25, 2022

Using the neokey on a board without builtin adafruit_pixelbuf (using the python version) I get that:

code.py output:
Traceback (most recent call last):
  File "code.py", line 9, in <module>
  File "adafruit_neokey/neokey1x4.py", line 64, in __init__
  File "adafruit_seesaw/neopixel.py", line 80, in __init__
TypeError: unexpected keyword argument 'size'

And indeed the size argument is called "n" in that version.
It's the positional argument anyway, no need for a name.

Copy link
Member

@tekktrik tekktrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, nice fix! Probably worth fixing the adafruit_pixelbuf library at some point, but you're right, positional is fine (and what people are most likely to do).

@tekktrik tekktrik merged commit 159c8ec into adafruit:main Jul 25, 2022
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jul 26, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_MONSTERM4SK to 0.3.9 from 0.3.8:
  > Updated setup.py, reverted release.yml

Updating https://github.com/adafruit/Adafruit_CircuitPython_Seesaw to 1.11.2 from 1.10.12:
  > Merge pull request adafruit/Adafruit_CircuitPython_seesaw#108 from carlfj/patch-1
  > Merge pull request adafruit/Adafruit_CircuitPython_seesaw#109 from Neradoc/nera-fix-pixelbuf-size
  > Merge pull request adafruit/Adafruit_CircuitPython_seesaw#106 from Neradoc/use-pixelbuf
  > Changed .env to .venv in README.rst
  > Removed duplicate-code from library pylint disable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants