Skip to content

Library needs simpletest example #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kattni opened this issue Apr 10, 2020 · 4 comments · Fixed by #20
Closed

Library needs simpletest example #19

kattni opened this issue Apr 10, 2020 · 4 comments · Fixed by #20

Comments

@kattni
Copy link
Contributor

kattni commented Apr 10, 2020

This library has no simpletest example. This was discussed in #12 but it did not result in the addition of a simpletest. I'm opening a new issue to being this discussion up again.

@jerryneedell or @brentru Do you have any suggestions?
@brentru
Copy link
Member

brentru commented Apr 10, 2020

@kattni The example which flashes nina-fw to an esp32 would be a good simpletest -> https://github.com/adafruit/Adafruit_CircuitPython_miniesptool/blob/master/examples/miniesptool_esp32nina.py

@kattni
Copy link
Contributor Author

kattni commented Apr 10, 2020

@brentru Thank you so much!

@kattni
Copy link
Contributor Author

kattni commented Apr 10, 2020

@brentru Would you suggest calling it miniesptool_simpletest or miniesptool_esls32nina_simpletest ?

@brentru
Copy link
Member

brentru commented Apr 10, 2020

@kattni miniesptool_simpletest is OK

@kattni kattni mentioned this issue Apr 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename to simpletest to fit standards. adafruit/Adafruit_CircuitPython_miniesptool
2 participants
@brentru @kattni