Skip to content

Example should be renamed to include simpletest #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kattni opened this issue Sep 30, 2019 · 5 comments
Closed

Example should be renamed to include simpletest #12

kattni opened this issue Sep 30, 2019 · 5 comments
Labels
good first issue Good for newcomers

Comments

@kattni
Copy link
Contributor

kattni commented Sep 30, 2019

Example miniesptool_esp32multifile.py should be renamed to miniesptool_esp32multifile_simpletest.py to fit with CircuitPython library standards.

@kattni kattni added the good first issue Good for newcomers label Sep 30, 2019
@jerryneedell
Copy link
Contributor

In this case, the examples are really not "simple tests" they are used to load code to the esp32 module. A user should not run this to "see how it works". Is "simpletest" really the appropriate name?

@kattni
Copy link
Contributor Author

kattni commented Sep 30, 2019

@jerryneedell Perhaps not. I guessed. What would be considered a simpletest for this library?

@jerryneedell
Copy link
Contributor

I'm not sure there really is one. It would be like having a simpletest for a .uf2 file. If you run it , it will write the file to your board.

@kattni
Copy link
Contributor Author

kattni commented Sep 30, 2019

Fair enough. Closing this issue. I think we should consider figuring out what would be considered a simpletest for this lib though, if at all possible.

@kattni kattni closed this as completed Sep 30, 2019
@jerryneedell
Copy link
Contributor

perhaps @brentru would have some ideas -- this may fit into his guide for the esp32spi...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants