Skip to content

Try all qr_types when automatically sizing #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Try all qr_types when automatically sizing #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion adafruit_miniqr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ def add_data(self, data):
self.data_list.append(data)
datalen = sum(len(x) for x in self.data_list)
if not self.type:
for qr_type in range(1, 6):
for qr_type in range(1, 10):
rs_blocks = _get_rs_blocks(qr_type, self.ECC)
total_data_count = 0
for block in rs_blocks:
Expand Down
7 changes: 4 additions & 3 deletions tests/test_unit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,9 @@ def test_qr_pattern_mask(self):
def test_qr_auto(self):
# Confirm that increasing message size increases the matrix size monotonically
sizes = []
for i in range(14): # size 41 crashes
_m = enc(b"aBc!1234" * i)
for i in range(29):
msg = b"aBc!1234" * i
_m = enc(msg)
sizes.append(_m.width)
self.assertTrue(len(set(sizes)) > 1)
self.assertEqual(sizes, sorted(sizes))
Expand Down Expand Up @@ -89,7 +90,7 @@ def test_qr_all(self):

def test_qr_maximum(self):
msg = bytes([random.randrange(32, 127) for i in range(230)])
_a = enc(msg, qr_type=9)
_a = enc(msg)
self.assertTrue(_a is not None)


Expand Down