Added fromisoformat() to date and datetime #2
Conversation
|
@makermelissa This looks like an elegant solution to the Could you add the test for The CPython source is here, |
|
Sure thing @brentru |
|
Update: once I started trying out the unit tests, I realized I hadn't implemented this properly with it defaulting to zeroes rather than raising ValueErrors on a bad format. Also, my implementation wasn't complete, so I'm reworking it and doing a proper implementation and that's coming along nicely. |
|
There are more unit tests that are not quite passing, but at least some of them have been enabled/added. |
|
They can be worked on and improved at a later date, but this PR provides the core functionality that I needed and is ready for review. |
|
At this point most of the unit tests that don't pass are due to other functions not being implemented. I updated some of the skip message to reflect this better. |
There was a problem hiding this comment.
@makermelissa this looks good to me! Thanks for adding the unittests.
Updating https://github.com/adafruit/Adafruit_CircuitPython_datetime to 1.1.0 from 1.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_datetime#2 from makermelissa/master Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 2.14.0 from 2.12.4: > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#120 from jposada202020/bitmap_label_base_alignment > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#115 from jposada202020/base_alignement_proposal
Unfortunately CircuitPython doesn't yet support Counted Repetitions or Non-Capturing groups, so the regex is on the longer side.