Skip to content

add package_folder_prefix #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 19, 2021
Merged

add package_folder_prefix #11

merged 2 commits into from
Dec 19, 2021

Conversation

dhalbert
Copy link
Contributor

The asyncio directory was not being included because it did not start with adafruit_, the default value for circuitpython-build-bundles --package_folder_prefix. So the library releases were not including the code of the library.

@dhalbert dhalbert requested a review from a team December 19, 2021 05:13
FoamyGuy
FoamyGuy approved these changes Dec 19, 2021
View reviewed changes
Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Tried testing build-bundles locally but I think I have out of date mpy-cross or some part of the toolchain. I was not getting successfully bundle builds but I think it's likely my environment not related to changes from this PR.

@dhalbert
Copy link
Contributor Author

Thanks, I will merge, and make a release, and check it.

@dhalbert dhalbert merged commit 81cbc88 into main Dec 19, 2021
@dhalbert dhalbert deleted the dhalbert-package-folder-prefix branch December 19, 2021 14:51
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Dec 20, 2021
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@e796bc0)
0722cf1 
Updating https://github.com/adafruit/Adafruit_CircuitPython_asyncio to 0.5.3 from 0.5.1:
  > Update Python to 3.10 to get latest circuitpython-build-tools
  > Merge pull request adafruit/Adafruit_CircuitPython_asyncio#11 from adafruit/dhalbert-package-folder-prefix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FoamyGuy FoamyGuy FoamyGuy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhalbert @FoamyGuy