Remove assert's
#85
Merged
Remove assert's
#85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhalbert
requested changes
Dec 20, 2022
There was a problem hiding this comment.
Thanks! These are not really assertion failures, in many cases, but RuntimeErrors or similar, because they do not reflect an error in the code (which is what assertions are checking). So could you consider what exception you would like to be raised for these? The wifi exceptions for similar problems could be used as a model, if they make sense.
|
This was a minimally invasive pr, however since requested, I will update the exceptions based on |
dhalbert
approved these changes
Dec 20, 2022
|
Updated to fix conflicts & to switch |
|
Is this good to go now that changes from |
|
Yep, its done. |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jan 7, 2023
Updating https://github.com/adafruit/Adafruit_CircuitPython_Wiznet5k to 1.13.0 from 1.12.18: > Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#85 from bill88t/main Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is following #67 and is independent to it.
Closes #83 .