Skip to content

Fixed issues with UDP datagram receives #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 5, 2022
Merged

Fixed issues with UDP datagram receives #62

merged 4 commits into from
Jul 5, 2022

Conversation

tom24
Copy link
Contributor

@tom24 tom24 commented Jul 1, 2022

  1. socket.recvfrom did not return remote address
  2. datagrams were not delimited on message boundaries
  3. the scheme for keeping track of partially read datagrams
    failed if multiple datagrams were being received at once.

Also, the _dns attribute was not initted to a tuple in case it
is read before it is ever explicitly set.

Tom Thompson added 3 commits July 1, 2022 15:50
Fixed issues with UDP datagram receives
be71b45 
1. socket.recvfrom did not return remote address
2. datagrams were not delimited on message boundaries
3. the scheme for keeping track of partially read datagrams
   failed if multiple datagrams were being received at once.

Also, the _dns attribute is not initted to a tuple in case it
is read before it is ever explicitly set.
Disable pylint attribute limit
131c83e
Remove trailing whitespace
c3cceaf
@chabala
Copy link
Contributor

chabala commented Jul 1, 2022

Thanks for making this PR to fix #60 & #61. Looks like the build is failing due to the formatting rules. If you can make changes to appease that check, I'm excited to see these changes get integrated.

@brentru brentru self-requested a review July 5, 2022 15:23
@brentru
Copy link
Member

brentru commented Jul 5, 2022

This seems like it resolves #60 and #61, I see no issues with the code and it passes tests.

@brentru brentru merged commit 679af97 into adafruit:main Jul 5, 2022
@chabala
Copy link
Contributor

chabala commented Jul 5, 2022

Will you cut a release as well @brentru? Perhaps that should be automatic on merge.

@brentru
Copy link
Member

brentru commented Jul 5, 2022

A release will be cut by @evaherrada

adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jul 6, 2022
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@17faac3)
c199919 
Updating https://github.com/adafruit/Adafruit_CircuitPython_Wiznet5k to 1.12.8 from 1.12.7:
  > Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#62 from tom24/udpfixes

Updating https://github.com/adafruit/Adafruit_CircuitPython_Dash_Dis to 1.1.7 from 1.1.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_Dash_Dis#5 from Neradoc/add-requirements

Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Shapes to 2.5.0 from 2.4.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_Display_Shapes#50 from bablokb/sparkline_opt

Updating https://github.com/adafruit/Adafruit_CircuitPython_HTTPServer to 0.2.0 from 0.1.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_HTTPServer#7 from karlfl/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_OAuth2 to 1.0.10 from 1.0.9:
  > Merge pull request adafruit/Adafruit_CircuitPython_OAuth2#8 from tcfranks/main
This was referenced Sep 15, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentru brentru brentru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tom24 @chabala @brentru