send large data in 2kb chunks #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

brentru merged 2 commits into adafruit:main from masgari:main

Mar 14, 2022

Contributor

masgari commented Mar 12, 2022

max size of buffer is 2kb (0x800)

Adafruit_CircuitPython_Wiznet5k/adafruit_wiznet5k/adafruit_wiznet5k.py

Line 785 in 7fd3be6

if len(buffer) > SOCK_SIZE:


          send large data in 2kb chunks

c39640d

Member

tekktrik commented Mar 12, 2022

Hey @masgari! Thanks for the contribution! Looks like the CI wants the code to be reformatted. You can fix the CI error using pre-commit, here's a link with information on how to do so:

https://learn.adafruit.com/creating-and-sharing-a-circuitpython-library/check-your-code


          reformat code using black/pre-commit

a713177

tekktrik requested a review from a team

March 13, 2022 18:44

brentru approved these changes

View reviewed changes

Member

brentru left a comment

Length checks are always appreciated, thanks @masgari.

brentru merged commit cde1415 into adafruit:main

adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request


          Automated update by Adabot (adafruit/adabot@8ce3914)

083992e

Updating https://github.com/adafruit/Adafruit_CircuitPython_APDS9960 to 3.1.0 from 3.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_APDS9960#42 from bablokb/4upstream
  > Fixed readthedocs build
  > Post-patch cleanup

Updating https://github.com/adafruit/Adafruit_CircuitPython_LSM6DS to 4.4.1 from 4.3.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_LSM6DS#52 from jerryneedell/jerryn_mlc

Updating https://github.com/adafruit/Adafruit_CircuitPython_ST7789 to 1.5.6 from 1.5.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_ST7789#30 from makermelissa/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_VL53L0X to 3.6.0 from 3.5.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_VL53L0X#35 from whogben/main
  > Fixed readthedocs build
  > Consolidate Documentation sections of README

Updating https://github.com/adafruit/Adafruit_CircuitPython_Wiznet5k to 1.12.3 from 1.12.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#54 from masgari/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE to 8.2.2 from 8.2.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_BLE#159 from dhalbert/nus-doc-fix

Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE_LYWSD03MMC to 1.0.6 from 1.0.5:
  > Fixed readthedocs build

Updating https://github.com/adafruit/Adafruit_CircuitPython_MagTag to 2.1.8 from 2.1.7:
  > Merge pull request adafruit/Adafruit_CircuitPython_MagTag#82 from makermelissa/main
  > Merge pull request adafruit/Adafruit_CircuitPython_MagTag#81 from makermelissa/main
  > Fixed readthedocs build

Updating https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT to 5.3.0 from 5.2.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#106 from dgriswo/subscription_logging

Updating https://github.com/adafruit/Adafruit_CircuitPython_PortalBase to 1.11.1 from 1.11.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_PortalBase#64 from makermelissa/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_WSGI to 1.1.9 from 1.1.8:
  > Merge pull request adafruit/Adafruit_CircuitPython_WSGI#13 from tekktrik/dev/clearer-bad-return
  > Fixed readthedocs build
  > Post-patch cleanup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet