Skip to content

change reset line transition #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2022

Conversation

chabala
Copy link
Contributor

@chabala chabala commented Feb 18, 2022

Resolves #51

After testing, it seems no timing change is needed, only the order of the transition needed to change.

My test code revises the earlier gist to remove all external reset logic, and use GP20 as the reset line.

https://gist.github.com/chabala/e8cc48355c03a34c209dba43b03a5526

Also, would it be worthwhile to have this example code in-project rather than in gists?

Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good and the rationale in the #51 makes sense to me.

I don't have the RP2040 Hat to test with. But I did do a quick check with the Ethernet Feather wing and the examples scripts in this repo, they all still run successfully and have no change in behavior as expected since the Ethernet Featherwing doesn't need to use reset pin during normal operation.

@FoamyGuy FoamyGuy merged commit 7fd3be6 into adafruit:main Feb 21, 2022
@FoamyGuy
Copy link
Contributor

I do think it would be worthwhile to add an example for that device to this repo, just be sure there are comments that explain the specific hardware it's made to work with.

if you want to make a follow up PR to add that example inside of the exampels dir that would be awesome.

Thanks for looking into this and working on the fix @chabala

Copy link
Member

@anecdata anecdata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed working on W5100S-EVB-Pico with the gist code.py. Also now using the change (and the correct pin) in my regular application. Thanks, @chabala!

@chabala
Copy link
Contributor Author

chabala commented Feb 21, 2022

Thank you both. @anecdata as you are the original author of the example code, would you like the opportunity to add it into the examples?

@chabala chabala deleted the wiznet5k-reset-transition branch February 21, 2022 23:21
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Feb 22, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_74HC595 to 1.3.4 from 1.3.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_74HC595#22 from Chao8219/main
  > Fixed readthedocs build
  > Consolidate Documentation sections of README

Updating https://github.com/adafruit/Adafruit_CircuitPython_Wiznet5k to 1.12.2 from 1.12.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#52 from chabala/wiznet5k-reset-transition
  > Fixed readthedocs build
  > Post-patch cleanup
  > Post-patch cleanup
  > Consolidate Documentation sections of README
  > Consolidate Documentation sections of README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

W5100S-EVB-Pico reset pin and reset logic
3 participants