Skip to content

Prefix global constants with _ when possible #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dhalbert opened this issue Dec 20, 2022 · 0 comments · Fixed by #86
Closed

Prefix global constants with _ when possible #84

dhalbert opened this issue Dec 20, 2022 · 0 comments · Fixed by #86
Labels
enhancement New feature or request

Comments

@dhalbert
Copy link
Contributor

There are a large number of top-level constants in the code. If the global names do not need to be accessible outside their files, they could be prefixed with _ to eliminate them from taking up space in the compiled code.
@dhalbert dhalbert added the enhancement New feature or request label Dec 20, 2022
@bill88t bill88t mentioned this issue Dec 20, 2022
Merged
@BiffoBear BiffoBear mentioned this issue Dec 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

_GLOBAL constants
1 participant
@dhalbert