Skip to content

#16 use the request path in the exception #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 21, 2022
Merged

#16 use the request path in the exception #17

Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ff31ec9
#16 use the request path in the exception
dannystaple May 8, 2022
d272883
Change the exception wording to match the returned item.
dannystaple May 18, 2022
09cbb07
Request handler from path makes more sense.
dannystaple May 18, 2022
2050761
Pylint fix.
dannystaple May 18, 2022
d91ba3c
Sort out the unwanted indents. Also make the message a little less wo…
dannystaple May 20, 2022
9b2275c
Format
dannystaple May 20, 2022
fb6cb46
Facepalm. Fix this.
dannystaple May 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions adafruit_wsgi/wsgi_app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,9 +70,8 @@ def __call__(self, environ: Dict[str, str], start_response: Callable):
status, headers, resp_data = route["func"](request, *args)
except (ValueError, TypeError) as err:
raise RuntimeError(
"Proper HTTP response return not given for request handler '{}'".format(
route["func"].__name__
)
"Proper HTTP response not returned by request handler for path "
+ "'{request.path}'"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the f is missing for the f-string

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Facepalm. Fixed it.

) from err
start_response(status, headers)
return resp_data
Expand Down