New adafruit_ws2801.py #1
Conversation
…CircuitPython_DotStar and protocol dervied from https://github.com/adafruit/Adafruit-WS2801-Library/blob/master/Adafruit_WS2801.cpp and tested on a 50 12mm led string. WS2801 constructor argument brightness unlikely to work at the momemt due to inherited strangeness/bug.
There was a problem hiding this comment.
Hiya! this looks like a great start, but needs some extra files to get going.
Please check out
https://learn.adafruit.com/creating-and-sharing-a-circuitpython-library/creating-a-library
and run the 'cookiecutter' in this directory to create all the extra files like so!
$ cookiecutter gh:adafruit/cookiecutter-adafruit-circuitpython
You've downloaded /c/Users/ladyada/.cookiecutters/cookiecutter-adafruit-circuitpython before. Is it okay to delete and re-download it? [yes]:
library_name: WS2801
depends_on_bus_device []: y
depends_on_register []:
author: Your Name Here
github_user [adafruit]:
library_prefix []: Adafruit
company []:
In the end you'll have all these files like this repo: https://github.com/adafruit/Adafruit_CircuitPython_TSL2591
Thank you! it is appreciated and will make this library the best ever :)
|
We're available on Discord and the forums if you have questions! Good job getting it going! |
|
I'll take a look at this in about 2.5 weeks, got some other stuff to do. |
|
All good! |
|
@kevinjwalters Do you still plan on circling back to this PR? |
|
Just looking at this now... |
…adafruit-circuitpython as per recommendation in adafruit#1 (review) with the exception of adafruit_dotstar.py
…ted by cookiecutter
…ibutors in LICENSE and docs/conf.py
|
Whilst I remember, the cookiecutter script/template produces copyrights with 2017 in them. Perhaps this should be configurable and default to the current year? |
|
Good idea! Would you mind changing cookiecutter to do it?
…On Fri, Mar 16, 2018 at 1:32 PM kevinjwalters ***@***.***> wrote:
Whilst I remember, the cookiecutter script/template produces copyrights
with 2017 in them. Perhaps this should be configurable and default to the
current year?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADNqXX5y7wiHaUyJwgtPxR-z_50v1PPks5tfCF0gaJpZM4R7-DL>
.
|
…f understanding of the python setter/getter @Property magic
…_brightness assignment
…uit_dotstar.py - brightness() now calls show() if auto_write - see adafruit/Adafruit_CircuitPython_DotStar@503e854#diff-18059db786163024e172bdbae20fb7b1
…ple code for 25 string led.
…still a bit odd for a string of 25!
|
Travis says:
How should I deal with that? |
…f.py - it no longer rains on me.
|
Ok, I worked out how to make all checks pass. I'd suggest a good look over this as i'm still a bit new to Python and this is my first Adafruit library creation. |
tannewt
dismissed
ladyada’s stale review
@kevinjwalters had added cookiecutter files.
As discussed in https://forums.adafruit.com/viewtopic.php?f=60&t=129619
New adafruit_ws2801.py based on https://github.com/adafruit/Adafruit_CircuitPython_DotStar and protocol dervied from https://github.com/adafruit/Adafruit-WS2801-Library/blob/master/Adafruit_WS2801.cpp and tested on a 50 12mm led string.
WS2801 constructor argument brightness unlikely to work at the momemt due to inherited strangeness/bug.