-
Notifications
You must be signed in to change notification settings - Fork 14
Add offset setting, add type hints #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
caternuson
merged 15 commits into
adafruit:main
from
tekktrik:feature/add-manual-offset
Nov 24, 2021
Merged
Changes from 7 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
9100ea9
Add type hints
tekktrik de087a7
Add manual offset getting/setting
tekktrik 977a013
Changed property to "offset"
tekktrik 74c318f
Remove read of offset in __init__
tekktrik ba462ae
Allow setting of offset during __init__
tekktrik 4e56940
Reformatted per pre-commit
tekktrik ce7e81d
Create example for adding manual offset
tekktrik 3d5b2b8
Simplify packing offset into byte using struct.pack()
tekktrik edbd33b
Reformatted per pre-commit,
tekktrik 12d5394
Move import of struct
tekktrik 008ac3a
Convert offset example to calibration example
tekktrik 3ccf54d
Add commented out line in simple test for initializing sensor with of…
tekktrik 82a0669
Reformatted per black
tekktrik 74360e7
Shorten line per pylint
tekktrik 4fa94ae
Add offset to commented out code, expand explanation
tekktrik File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
# SPDX-FileCopyrightText: 2018 Tony DiCola for Adafruit Industries | ||
# SPDX-License-Identifier: MIT | ||
|
||
# Demo of reading the range and lux from the VL6180x distance sensor and | ||
# printing it every second. | ||
|
||
import time | ||
|
||
import board | ||
import busio | ||
|
||
import adafruit_vl6180x | ||
|
||
|
||
# Create I2C bus. | ||
i2c = busio.I2C(board.SCL, board.SDA) | ||
|
||
# Create sensor instance, with an offset value determined by manual calibration. | ||
sensor = adafruit_vl6180x.VL6180X(i2c, offset=10) | ||
|
||
# Main loop prints the range and lux every second: | ||
while True: | ||
# Read the range in millimeters and print it. | ||
range_mm = sensor.range | ||
print("Range: {0}mm".format(range_mm)) | ||
# Read the light, note this requires specifying a gain value: | ||
# - adafruit_vl6180x.ALS_GAIN_1 = 1x | ||
# - adafruit_vl6180x.ALS_GAIN_1_25 = 1.25x | ||
# - adafruit_vl6180x.ALS_GAIN_1_67 = 1.67x | ||
# - adafruit_vl6180x.ALS_GAIN_2_5 = 2.5x | ||
# - adafruit_vl6180x.ALS_GAIN_5 = 5x | ||
# - adafruit_vl6180x.ALS_GAIN_10 = 10x | ||
# - adafruit_vl6180x.ALS_GAIN_20 = 20x | ||
# - adafruit_vl6180x.ALS_GAIN_40 = 40x | ||
light_lux = sensor.read_lux(adafruit_vl6180x.ALS_GAIN_1) | ||
print("Light (1x gain): {0}lux".format(light_lux)) | ||
# Delay for a second. | ||
time.sleep(1.0) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use
struct.pack
here. Can also let it do the range checking. For example, all this could be:From AN4545:

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, that looks much simpler and cleaner, thanks!