update resolution #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ladyada
approved these changes
Jan 31, 2025
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Feb 12, 2025
Updating https://github.com/adafruit/Adafruit_CircuitPython_VEML7700 to 2.1.2 from 2.1.1: > Merge pull request adafruit/Adafruit_CircuitPython_VEML7700#34 from FoamyGuy/update_resolution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ladyada
Resolves: #32
their main datasheet link stays updated always pointing to the latest revision. The link on the downloads section of the learn guide is that main always updated link.
I confirmed in the current revision it lists
.0042as the resolution in a handful of places and doesn't list.0036anywhere.I did also find an older revision of the datasheet here: https://www.sigmaelectronica.net/wp-content/uploads/2019/10/veml7700-Datasheet.pdf that does show the
.0036value. So it seems like they indeed changed that value some time along the way.The arduino library is also using
.0036, I can change it over there if we want to have this change