Skip to content

Made changes to bring library closer to cookiecutter #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 24, 2022
Merged

Conversation

evaherrada
Copy link
Collaborator

No description provided.

@evaherrada evaherrada requested review from dhalbert and a team March 24, 2022 20:18
@github-actions
Copy link

👋 Thanks for this pull request! Unfortunately, it looks like the automated continuous integration (CI) test(s) failed. These can be tricky to fix so we've written a guide on how to fix them locally. It has pages about running pre-commit locally and another about building the docs locally with sphinx. Thanks for contributing to CircuitPython! If you have more questions, feel free to join the Adafruit Discord and post in #circuitpython-dev.

Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typing is a library from CPython, so I'm a little reluctant to rename the example to be typing. Does it need to match for other reasons?

@dhalbert
Copy link
Contributor

dhalbert commented Mar 24, 2022

Maybe this library should be called typing_circuitpython, and the repo named Adafruit_CircuitPython_Typing_CircuitPython?? That would get rid of the naming inconsistencies.

@evaherrada
Copy link
Collaborator Author

Just for adabot. However I could also make adabot be ok with examples following the format of: CircuitPython_LIBNAME_EXAMPLENAME.py

@dhalbert
Copy link
Contributor

Maybe this library should be called typing_circuitpython, and the repo named Adafruit_CircuitPython_Typing_CircuitPython?? That would get rid of the naming inconsistencies.

I'm willing to keep having the example renamed and make renaming the library a long-term issue.

@evaherrada
Copy link
Collaborator Author

Yeah that could work, although I personally would want to avoid that as I think it doesn't look great, but I understand why it would make sense to do

@dhalbert dhalbert merged commit 9d99f06 into main Mar 24, 2022
@evaherrada evaherrada deleted the cookiecutter branch March 24, 2022 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants