use string instead of import for framebufferio #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhalbert
approved these changes
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
framebufferiodoes not exist in Blinka_Displayio, so this was causing an import error when attempting to use it for a type annotation.I've updated the alias to use a string instead of the imported module for the type, in an environment were circuitpython-stubs is installed I think it might see the one from that in some IDEs still.
If framebufferio ever gets implemented in Blinka Displayio we could swap this back to importing.
This will resolve the actions failure from here: https://github.com/adafruit/Adafruit_CircuitPython_CursorControl/actions/runs/15351252647/job/43199774642?pr=41#step:2:1093
I tested the changed code successfully by building the docs for that PR branch locally with these changes.