Skip to content

allow use in Python 3.7 #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 25, 2022
Merged

allow use in Python 3.7 #4

merged 1 commit into from
Feb 25, 2022

Conversation

dhalbert
Copy link
Contributor

Fixes #3.

  • Use typing_extensions for Protocol for Python <= 3.7.
  • Don't use / to indicate position-only arguments.

Tested on Python 3.7.11.

@dhalbert dhalbert requested a review from a team February 25, 2022 02:48
ladyada
ladyada approved these changes Feb 25, 2022
View reviewed changes
Copy link
Member

@ladyada ladyada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seemes ok

@dhalbert
Copy link
Contributor Author

I will merge and release this tonight so it gets in the bundle. If it's broken we can fix again tomorrow, but I think it's OK.

@dhalbert dhalbert merged commit 60e5346 into adafruit:main Feb 25, 2022
@dhalbert dhalbert deleted the support-python-3.7 branch February 25, 2022 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ladyada ladyada ladyada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1.1.0 requires python 3.8
2 participants
@dhalbert @ladyada