Skip to content

Stop building mpy bundles in build and release workflows #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 13, 2024
Merged

Stop building mpy bundles in build and release workflows #37

merged 1 commit into from
Feb 13, 2024

Conversation

tekktrik
Copy link
Member

Resolves #34
Resolves #36

@tekktrik tekktrik requested a review from dhalbert February 13, 2024 18:06
dhalbert
dhalbert reviewed Feb 13, 2024
View reviewed changes
Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I look in the CI build log I still see it zipping up .mpy files, so that's confusing.

@tekktrik
Copy link
Member Author

I'll do a deep dive into the action and see what the issue, thanks for catching that.

@tekktrik tekktrik marked this pull request as draft February 13, 2024 18:20
@tekktrik
Copy link
Member Author

Oh I think I found the issue! I'll fix the workflow.

@tekktrik tekktrik marked this pull request as ready for review February 13, 2024 18:28
@tekktrik
Copy link
Member Author

Alright, after rerunning the action, it seems to correctly skip the mpy bundles now.

@tekktrik tekktrik requested a review from dhalbert February 13, 2024 18:37
dhalbert
dhalbert approved these changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, go ahead and make a release and let's see what happens!

@dhalbert dhalbert merged commit 1b2d687 into adafruit:main Feb 13, 2024
@tekktrik
Copy link
Member Author

Success!

@tekktrik tekktrik deleted the dev/ignore-mpy-bundle branch February 13, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do not do mpy-cross builds of this library. mpy zips don't contain mpy files
2 participants
@tekktrik @dhalbert