Skip to content

Add PIL.Image protocol #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 25, 2022
Merged

Conversation

tekktrik
Copy link
Member

This would be helpful in adafruit_framebuf but I've also seen other libraries that use PIL.Images without requiring the package to be downloaded on installation. This protocol allows for type annotations in this case.

Another fix would be to require pip to install PIL when the library is downloaded, but this allows that functionality to remain optional.

@tekktrik tekktrik requested a review from a team April 22, 2022 19:26
Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @tekktrik

@FoamyGuy FoamyGuy merged commit 33d26e8 into adafruit:main Apr 25, 2022
@tekktrik tekktrik deleted the doc/add-image-protocol branch December 1, 2022 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants