Add PWMOut protocol #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
PWMOutprotocol is needed for when Blinka doesn't define it, but a library uses it for type annotations. This is at least needed foradafruit_motorsince it can be used viaadafruit_motorkiton Blinka, but currently fails because some platforms don't implementPWMOut(see adafruit/Adafruit_CircuitPython_MotorKit#45).I'm adding it here as opposed to the library because I'm not sure if this will come up again. If it makes more sense to define in the library itself up in the typing block, I'm happy to move things there!
Merging this (or moving into
adafruit_motorwill allow a for a fix to be written for the aforementioned issue.