Skip to content

ATime not accounted for in Overflow Detection #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Rvice opened this issue Aug 9, 2018 · 1 comment
Closed

ATime not accounted for in Overflow Detection #5

Rvice opened this issue Aug 9, 2018 · 1 comment

Comments

@Rvice
Copy link
Contributor

Rvice commented Aug 9, 2018 •
edited
Loading

Adafruit_CircuitPython_TSL2591/adafruit_tsl2591.py

Line 252 in 0fa3c2e

if channel_0 == 0xFFFF or channel_1 == 0xFFFF:

This should use the ATime reference to determine the resolution for Overflow. If 100 ms, this is >= 36863 counts for an overflow.

37889 observed for saturation in the VIR channel, which exceeds the datasheet value of 36863 (0x8FFF)
Rvice added a commit to Rvice/Adafruit_CircuitPython_TSL2591 that referenced this issue Aug 9, 2018
@Rvice
Modified for Issue adafruit#5 for the maxCounts to determine if the s…
e427332 
…ensor overflowed
@Rvice Rvice mentioned this issue Aug 9, 2018
Merged
@Rvice
Copy link
Contributor Author

Rvice commented Aug 13, 2018

Fxed in PR #6

@Rvice Rvice closed this as completed Aug 13, 2018
@Rvice Rvice mentioned this issue Aug 22, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Rvice