revise lux calculation to accept 0 reading without error #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
crazy edge case. nice work! |
tannewt
pushed a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Dec 23, 2017
Updating https://github.com/adafruit/Adafruit_CircuitPython_TSL2561 to 3.0.1 from 3.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_TSL2561#11 from jerryneedell/jerryn_fixlux
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes lux calculation to accept a ratio of 0 (use >=0 instead of >0 ). Simplified if/elif tests to only test upper limit on each case. It is not necessary to test both lower and upper each time since it will only fall through if the value exceeds the lower limit.