Initial commit of working version #1
Conversation
adafruit_tmp007.py
Outdated
| control |= _TMP007_CFG_MODEON | ||
| self._write_u16(_TMP007_CONFIG, control) | ||
|
|
||
| def read_raw_voltage(self): |
There was a problem hiding this comment.
Please use properties for sensor values. I'd expect temperature for the object and sensor_temperature for the die temp. voltage can be private only.
There was a problem hiding this comment.
made properties -- the voltage is not actually used internally. I think it is to be available for detailed sensor calibration by the user.
adafruit_tmp007.py
Outdated
| """ | ||
| self._device = I2CDevice(i2c, address) | ||
|
|
||
| def begin(self, samplerate=CFG_16SAMPLE): |
There was a problem hiding this comment.
Fold this into __init__ so its going immediately. It can always be slept after.
There was a problem hiding this comment.
I merged begin int init and just throw an error if the ID is not valid. Is this what you wanted?
adafruit_tmp007.py
Outdated
|
|
||
| dev_id = self.read_register(_TMP007_DEVID) | ||
| if dev_id != 0x78: | ||
| raise ValueError('Init failed - Did not find TMP007') |
There was a problem hiding this comment.
RuntimeError please. The argument could be valid but the circuit setup wrong.
adafruit_tmp007.py
Outdated
| @@ -121,13 +119,15 @@ def sleep(self): | |||
| control &= ~(_TMP007_CFG_MODEON) | |||
| self._write_u16(_TMP007_CONFIG, control) | |||
|
|
|||
| @property | |||
There was a problem hiding this comment.
Sleep and wake should be functions because they are behavior rather than state.
This is my initial commit of a working version of the TMP007 driver.
I have tested it on a feather_m4_express
Comments welcome