Description
There are missing type annotations for some functions in this library.
The typing
module does not exist on CircuitPython devices so the import needs to be wrapped in try/except to catch the error for missing import. There is an example of how that is done here:
try:
from typing import List, Tuple
except ImportError:
pass
Once imported the typing annotations for the argument type(s), and return type(s) can be added to the function signature. Here is an example of a function that has had this done already:
def wrap_text_to_pixels(
string: str, max_width: int, font=None, indent0: str = "", indent1: str = ""
) -> List[str]:
If you are new to Git or Github we have a guide about contributing to our projects here: https://learn.adafruit.com/contribute-to-circuitpython-with-git-and-github
There is also a guide that covers our CI utilities and how to run them locally to ensure they will pass in Github Actions here: https://learn.adafruit.com/creating-and-sharing-a-circuitpython-library/check-your-code In particular the pages: Sharing docs on ReadTheDocs
and Check your code with pre-commit
contain the tools to install and commands to run locally to run the checks.
If you are attempting to resolve this issue and need help, you can post a comment on this issue and tag both @FoamyGuy and @kattni or reach out to us on Discord: https://adafru.it/discord in the #circuitpython-dev
channel.
The following locations are reported by mypy to be missing type annotations:
- adafruit_tlc59711.py:276
- adafruit_tlc59711.py:317
- adafruit_tlc59711.py:344
- adafruit_tlc59711.py:382
- adafruit_tlc59711.py:432
- adafruit_tlc59711.py:472
- adafruit_tlc59711.py:499
- adafruit_tlc59711.py:521
- adafruit_tlc59711.py:566
- adafruit_tlc59711.py:575
- adafruit_tlc59711.py:582
- adafruit_tlc59711.py:627
- adafruit_tlc59711.py:631
- adafruit_tlc59711.py:663
- adafruit_tlc59711.py:697
- adafruit_tlc59711.py:728
- adafruit_tlc59711.py:761
- adafruit_tlc59711.py:813
- adafruit_tlc59711.py:826
- adafruit_tlc59711.py:841
- adafruit_tlc59711.py:876
- adafruit_tlc59711.py:892
- adafruit_tlc59711.py:924
- adafruit_tlc59711.py:927
- adafruit_tlc59711.py:931
- adafruit_tlc59711.py:978
- adafruit_tlc59711.py:984
- adafruit_tlc59711.py:999
- adafruit_tlc59711.py:1014
- adafruit_tlc59711.py:1024
- adafruit_tlc59711.py:1042
- adafruit_tlc59711.py:1045
- adafruit_tlc59711.py:1049