Replaced asserts with exceptions #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating a README change
getting even again with adafruits lead repo
According to Issue adafruit#10 of the main repo, exceptions shall be used instead of asserts. I'm game.
|
Looks like Travis is failing on a few pylint things. Can you check them a push a new commit with fixes. |
|
Travis was lazy last night (my time) and after 15 minutes or so I gave up. Let's see if he likes my changes now. |
did some pylint beautifications
Travis being picky.
makermelissa
approved these changes
Feb 6, 2019
caternuson
requested changes
Feb 6, 2019
adafruit_tlc5947.py
Outdated
| @@ -104,7 +104,8 @@ def duty_cycle(self): | |||
|
|
|||
| @duty_cycle.setter | |||
| def duty_cycle(self, val): | |||
| assert 0 <= val <= 65535 | |||
| if (val < 0) or (val > 65535): | |||
There was a problem hiding this comment.
Remove ()s. The "pythonic" syntax is:
if val < 0 or val > 65535:Same for all other conditionals.
adafruit_tlc5947.py
Outdated
| @@ -128,6 +129,8 @@ def frequency(self, val): | |||
|
|
|||
|
|
|||
| def __init__(self, spi, latch, *, auto_write=True, num_drivers=1): | |||
| if num_drivers < 1: | |||
| raise ValueError("need at least one driver; {0} is not supported.".format(num_drivers)) | |||
There was a problem hiding this comment.
Capitalize first word in message.
Need at least...
Same for all messages.
|
Thanks for putting this back on the radar. I've got a few stylistic change requests. |
|
No problem. Now that you pointed those out, I agree. |
caternuson
approved these changes
Feb 11, 2019
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Feb 11, 2019
Updating https://github.com/adafruit/Adafruit_CircuitPython_TLC5947 to 1.2.2 from 1.2.1: > Merge pull request adafruit/Adafruit_CircuitPython_TLC5947#15 from ArthurDent62/ArthurDent62-exceptionNotAssert Updating https://github.com/adafruit/Adafruit_CircuitPython_TinyLoRa to 1.0.8 from 1.0.7: > Merge pull request adafruit/Adafruit_CircuitPython_TinyLoRa#20 from jerryneedell/jerryn_big_packet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to issue #10