Add color property to the TCS34725 class (closes #8). #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caternuson
reviewed
Oct 4, 2018
adafruit_tcs34725.py
Outdated
| Blue = 255 (0x0000ff), SlateGray = 7372944 (0x708090) | ||
| """ | ||
| r, g, b = self.color_rgb_bytes | ||
| return (r << 16) + (g << 8) + b |
There was a problem hiding this comment.
Is there a reason for using + instead of | here?
There was a problem hiding this comment.
Yep- I didn't think of it :)
Since I'm already doing bitwise stuff, I guess it would be more consistent if I used | instead of +. Shall I go ahead and change it?
|
Thanks for doing this. Looks good. Just have the question above in the review. |
For consistency, switch from '+' to '|' since bitwise operations are already being used. #13 (comment)
tannewt
pushed a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Oct 5, 2018
Updating https://github.com/adafruit/Adafruit_CircuitPython_ADS1x15 to 0.5.2 from 0.5.1: > Merge pull request adafruit/Adafruit_CircuitPython_ADS1x15#16 from iBug/patch-1 > ignore the board module imports in .pylintrc > Merge pull request adafruit/Adafruit_CircuitPython_ADS1x15#14 from adafruit/pypi_readme Updating https://github.com/adafruit/Adafruit_CircuitPython_TCS34725 to 3.1.1 from 3.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_TCS34725#13 from process1183/colorproperty > Merge pull request adafruit/Adafruit_CircuitPython_TCS34725#12 from VladMihai28/issue11 > ignore the board module imports in .pylintrc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I built the module and docs locally using the instructions in the README, as well as running pylint (10.00/10). I then tested my changes with an Adafruit Feather M0 Express and the Adafruit TCS34725 sensor board using a modified copy of the example tcs34725_simpletest.py. Sample output from this script: