Wait for other thread to unlock when not able to lock #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that this issue only occurs when using multiple threads with all of them constantly (without sleeping) trying to read values from different i2c busses over the multiplexer. |
|
Hm, @makermelissa and @tannewt this is interesting. This would imply that |
|
Ya, interesting. This is lightweight enough that I'd be ok with the change here and in bus device. This doesn't mean our drivers are threadsafe though. They are tested on micros without threads generally. |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jul 27, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_TCA9548A to 0.6.0 from 0.5.4: > Merge pull request adafruit/Adafruit_CircuitPython_TCA9548A#39 from GwnDaan/patch-1 > Changed .env to .venv in README.rst Updating https://github.com/adafruit/Adafruit_CircuitPython_BusDevice to 5.2.0 from 5.1.10: > Merge pull request adafruit/Adafruit_CircuitPython_BusDevice#91 from tekktrik/dev/use-sleep > Changed .env to .venv in README.rst Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Added the following libraries: Adafruit_CircuitPython_SI1145
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This request adds a sleep call of
0seconds in the try_lock function. This resolves an issue where the current thread is constantly trying to lock the i2c bus, without giving another thread the 'opportunity' to complete it's operation and unlock the i2c bus.This sleep call drastically improves performance on my pi zero board:
^ without the sleep call
^ using the sleep call
I'm not sure if this is the right way of 'unblocking' the i2c bus for other threads, but it's for sure 1000x better than before for me. Therefore I feel like it's worth sharing with others.