-
Notifications
You must be signed in to change notification settings - Fork 4
Adding 3x4 OLED demo #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Adding an example for the 3x4 numpad with an OLED to copy the Arduino lib example
👋 Thanks for this pull request! Unfortunately, it looks like the automated continuous integration (CI) test(s) failed. These can be tricky to fix so we've written a guide on how to fix them locally. It has pages about running pre-commit locally and another about building the docs locally with sphinx. Thanks for contributing to CircuitPython! If you have more questions, feel free to join the Adafruit Discord and post in #circuitpython-dev. |
Forgot pre-commit 🤦♀️
examples/tca8418_3x4_OLED.py
Outdated
event = keyevent & 0x7F | ||
event -= 1 | ||
# figure out row | ||
row = int(event / 10) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be event // 10
but I'm not sure if that's as beginner friendly as casting with int()
. Your call!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ohh yeah I like that, thanks! This example is more to show a good example for matrixes so I'd rather have the most pythonic way.
Ohh yeah I like that, thanks! This example is more to show a good example for matrixes so I'd rather have the most pythonic way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good to me! One small comment but it's not an issue so it's your call or merge as-is!
Well then that settles it! |
Updating https://github.com/adafruit/Adafruit_CircuitPython_MCP9600 to 1.3.6 from 1.3.5: > Merge pull request adafruit/Adafruit_CircuitPython_MCP9600#21 from kattni/doc-and-comment-fix Updating https://github.com/adafruit/Adafruit_CircuitPython_TCA8418 to 1.0.3 from 1.0.2: > Merge pull request adafruit/Adafruit_CircuitPython_TCA8418#8 from adafruit/3x4_oled > Merge pull request adafruit/Adafruit_CircuitPython_TCA8418#7 from adafruit/3x4_oled Updating https://github.com/adafruit/Adafruit_CircuitPython_Wiznet5k to 1.12.12 from 1.12.11: > Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#64 from alexsporn/fix/endiannes Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE_Beacon to 1.0.1 from 1.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_BLE_Beacon#1 from tekktrik/main Updating https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT to 5.5.1 from 5.5.0: > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#123 from rtwfroody/eagain2 Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Added the following libraries: Adafruit_CircuitPython_BLE_Beacon
Adding an example for the 3x4 numpad with an OLED to copy the Arduino lib example (https://github.com/adafruit/Adafruit_TCA8418/blob/main/examples/tca8418_3x4_OLED/tca8418_3x4_OLED.ino)