-
Notifications
You must be signed in to change notification settings - Fork 20
Adding type annotations and fixing float incompatibility #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
a61aad7
Adding type annotations. Had to include some math.floor to coerce flo…
RossK1 4b37794
Changes to fix CI errors on PR
RossK1 5dfe90f
Working on linting errors
RossK1 89d7a06
Linting for CI
RossK1 a1ecde6
Making return type changes as requested by review
RossK1 8f24c08
Fixing pylint issue
RossK1 409c013
Fixing black pre-commit
RossK1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this could be
bool
instead ofAny
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrected in the latest push together with the next change request.
The issue here is that mypy will complain. Technically
self.iopin.value
will return a boolean as it evaluates from the below function in the digitalio package. However, until that function is type-hinted to return bool, mypy thinks it is returning Any, and will hence complain as shown.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh, that makes sense. Thank you.
That is okay to have this one raising an error here for that reason. We'll get digitalio typed eventually as well to resolve this. I wonder where it would pull types for built-in modules from, the stubs package, or perhaps the Blinka implementation.