Initial version #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannewt
requested changes
Apr 24, 2018
adafruit_stmpe610.py
Outdated
| raise NotImplementedError | ||
|
|
||
|
|
||
| # pylint: disable=unused-variable |
adafruit_stmpe610.py
Outdated
| STMPE_TSC_CFG_SETTLE_5MS = const(0x04) | ||
| STMPE_TSC_CFG_SETTLE_10MS = const(0x05) | ||
| STMPE_TSC_CFG_SETTLE_50MS = const(0x06) | ||
| STMPE_TSC_CFG_SETTLE_100MS = const(0x07) |
There was a problem hiding this comment.
Do all of these need to be public? If you prefix them with _ they'll be omitted from the mpy and save memory when loaded.
| spi=busio.SPI(board.SCK,board.MOSI,board.MISO) | ||
| cs = digitalio.DigitalInOut(board.D6) | ||
| st=Adafruit_STMPE610_SPI(spi,cs) | ||
| print("Go Ahead - Touch the Screen - Make My Day!") |
adafruit_stmpe610.py
Outdated
|
|
||
|
|
||
| __version__ = "0.0.0-auto.0" | ||
| __repo__ = "https://github.com/adafruit/Adafruit_CircuitPython_stmpe610.git" |
There was a problem hiding this comment.
I believe STMPE should be capitalized to match the github repo name.
There was a problem hiding this comment.
Thanks - will change
README.rst
Outdated
| Usage Example | ||
| ============= | ||
|
|
||
| see examples in githup repository: https://github.com/adafruit/Adafruit_CIrcuitPython_STMPE610/exmaples |
There was a problem hiding this comment.
Mis-capitalization in CIrcuitPython
tannewt
approved these changes
Apr 27, 2018
|
Thank you @jerryneedell ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the initial version of a driver for the STMPE 610 Resistive Touch Screen Controller.
It supports both SPI and I2C.
For SPI - I have not yet addressed the issue reported by @ladyada where on some occasions, the wrong clock edge gets used. I have only seen this very rarely and I'm still thinking about how to handle it. Usually, just retrying fixes it.
as suggested, this is patterned "loosely" after the FocalTouch driver.
For the "touches" method, I arbitrarily allow it to return up to 4 touches at at time. The controller buffer can hold 128, but it is easy to run out of memory. I the paint demo, it never needs to buffer more than 1 anyway. Not sure if the buffering is useful or not, put it in as an example.
I have tested it on a 2.4inch TFT featherwing (SPI) and on a feather_m0_express with an stmpe610 breakout and touchscreen (PID 333) with SPI and I2C.
The paint demo has been tested on a 2.4 inch TFT Featherwing via a feather52 but the code in the repo is set up for feather_m0_express pins.
Comments welcome.