Skip to content

Enhanced compatibility #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 5, 2025
Merged

Enhanced compatibility #40

merged 4 commits into from
Apr 5, 2025

Conversation

alexleft
Copy link
Contributor

Add 2 arguments:

  1. bgr: bool, support for choosing bgr or rgb pixel order.
  2. invert: bool, support for sending color inverse command.

@alexleft
Add 2 arguments:
3bf6460 
1. bgr: bool, support for choosing  bgr or rgb pixel order.
2. invert: bool, support for sending color inverse command.
tannewt
tannewt requested changes Mar 31, 2025
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the addition! Please tweak it so it works the same if the new args aren't given.

alexleft added 2 commits April 3, 2025 00:08
@alexleft
Change the defualt value of Modify the default values of the __init__…
f08e364 
…() parameters to make it compatible with the behavior of old code.
@alexleft
Reformatted.
2304e3a
@alexleft alexleft requested a review from tannewt April 2, 2025 16:42
tannewt
tannewt approved these changes Apr 5, 2025
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tannewt tannewt merged commit 43a67c2 into adafruit:main Apr 5, 2025
1 check passed
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Apr 8, 2025
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@761055f)
df0a970 
Updating https://github.com/adafruit/Adafruit_CircuitPython_CST8XX to 1.0.3 from 1.0.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_CST8XX#2 from Neradoc/add-support-for-cst816-chips

Updating https://github.com/adafruit/Adafruit_CircuitPython_ST7789 to 2.1.0 from 2.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_ST7789#40 from alexleft/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_WM8960 to 1.0.2 from 1.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_WM8960#6 from relic-se/headphone_power_channel_swap
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexleft @tannewt