Skip to content

Create st7789_240x240_simpletest_Pimoroni_Pico_Explorer.py #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 18, 2021
Merged

Create st7789_240x240_simpletest_Pimoroni_Pico_Explorer.py #22

merged 2 commits into from
Feb 18, 2021

Conversation

wildestpixel
Copy link
Contributor

Example for Pimoroni Pico Explorer Display, correctly rotated

Example for Pimoroni Pico Explorer Display, correctly rotated
@ladyada
Copy link
Member

ladyada commented Feb 12, 2021

thanks please check the CI error to get CI passing then let us know its ready for review

@wildestpixel
Copy link
Contributor Author

wildestpixel commented Feb 12, 2021

Sorry @ladyada - this is defeating me as a complete novice on CI check's to know how to get past the failing on black. The code is the same as the simpletest with the change of the pin assignments and inclusion of import busio as pico has no assignment for SPI pins in board.

@tannewt
Copy link
Member

tannewt commented Feb 12, 2021

Are you editing the repo locally? Installing pre-commit can simplify this: https://pre-commit.com/#installation It'll auto-fix the files for you.

@ladyada ladyada requested a review from evaherrada February 15, 2021 17:33
@evaherrada
Copy link
Collaborator

@wildestpixel Hey. Thanks for adding that example. What @tannewt said is definitely correct, but since you're new to CIs, and the only check that is failing is the Black check, you should be able to get by just installing and running Black. There's a guide page on doing that here (https://learn.adafruit.com/improve-your-code-with-pylint/black) but the gist of it is that you install it with:

pip install black

or

pip3 install black

and then run it with:

black --target-version=py35 .

in the repository folder.

@wildestpixel
Copy link
Contributor Author

Will get on this shortly, had hectic few work days and new Mac to migrate to, thanks for the guidance :)

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @wildestpixel! Hope you are liking your new Mac!

@tannewt tannewt merged commit 451ba7f into adafruit:master Feb 18, 2021
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Feb 24, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_DHT to 3.5.6 from 3.5.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_DHT#62 from jposada202020/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_SSD1306 to 1.3.0 from 1.2.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_SSD1306#19 from SAK917/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_IL0373 to 1.3.6 from 1.3.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_IL0373#21 from makermelissa/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_INA260 to 1.3.0 from 1.2.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_INA260#15 from gpongelli/patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_MCP2515 to 1.0.4 from 1.0.3:
  > Changed py_modules to packages

Updating https://github.com/adafruit/Adafruit_CircuitPython_SCD30 to 2.0.3 from 2.0.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_SCD30#10 from caternuson/remove_asc

Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1608 to 1.2.5 from 1.2.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_SSD1608#10 from makermelissa/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1681 to 1.0.2 from 1.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_SSD1681#3 from makermelissa/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_ST7789 to 1.4.4 from 1.4.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_ST7789#22 from wildestpixel/patch-2

Updating https://github.com/adafruit/Adafruit_CircuitPython_VL53L0X to 3.3.6 from 3.3.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_VL53L0X#26 from caternuson/iss25

Updating https://github.com/adafruit/Adafruit_CircuitPython_VL6180X to 1.2.6 from 1.2.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_VL6180X#17 from OleMchls/patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_Gizmo to 1.3.0 from 1.2.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_Gizmo#15 from makermelissa/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_MagTag to 1.7.0 from 1.6.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_MagTag#56 from KTibow/patch-2

Updating https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT to 5.0.2 from 5.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#69 from dlizotte-uwo/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_Motor to 3.2.7 from 3.2.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_Motor#52 from jedgarpark/pico-dc-motor-example

Updating https://github.com/adafruit/Adafruit_CircuitPython_PIOASM to 0.1.6 from 0.1.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_PIOASM#8 from jepler/commas

Updating https://github.com/adafruit/Adafruit_CircuitPython_PortalBase to 1.2.3 from 1.2.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_PortalBase#13 from Neradoc/patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Added the following libraries: Adafruit_CircuitPython_SSD1681
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants